-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pausing the recording #1132
Conversation
I agree with adding it to the right-click menu, but I think we can also add a shortcut so that if you press Option+click it would pause instead of stopping. |
@skllcrn ^ |
- context menu allows for stopping or pausing/resuming recording - also added ability to pause recording by holding 'option' key while clicking tray icon
3aed6e6
to
5471c50
Compare
Maybe take the recording icon |
I think |
I would also drop the |
And maybe also include a quick way to quit Kap.
|
We also need to document the Option-click and right-click menu behavior. |
- shorten item names - re-arrange order of items - add quit option
Hmm, I wasn't really sure where to document this behaviour, I don't really see a "How To" guide or something in the README. An idea I had was to put a small page in the preferences window that could show users how to use the app. And something else we could also do is add a small walkthrough for when the user installs the app that teaches them how to use it. |
When you open a menu on macOS, it switches to a different run loop (it's complicated), so it blocks all timers. I'm not aware of any way to work around this with Electron, but it's fine. The timer doesn't need to update while the menu is open. It's just a convenience to see the current duration at the time of opening the menu. |
This is looking fantastic @thethomasz, the icon too, thanks both of you! |
I think was can just add a simple tip:
|
Great work, @thethomasz 👍 |
Tried implementing the feature request #129 to allow pausing a recording.
I'm not entirely sure if adding a "right-click" to the tray icon is a good solution to this, so I just wanted to create the PR first to get some feedback. I'm also not sure what the tray icon should look like when it's paused, and I'm not much of a designer myself. 😅
Fixes #129