Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deploy instructions #97

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Conversation

zhaofeng-shu33
Copy link
Member

@zhaofeng-shu33 zhaofeng-shu33 commented Mar 8, 2020

Should use flask logger in production mode.
Since the app class is called in subprocess and main is not entered.
Here is an excellent article dealing about this.
Related with Issue #35.

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #97 into master will increase coverage by 0.15%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   87.96%   88.12%   +0.15%     
==========================================
  Files           6        7       +1     
  Lines         457      463       +6     
==========================================
+ Hits          402      408       +6     
  Misses         55       55              
Flag Coverage Δ
#unittests 88.12% <60.00%> (+0.15%) ⬆️
Impacted Files Coverage Δ
app_instance.py 100.00% <100.00%> (ø)
app.py 83.01% <44.44%> (+0.08%) ⬆️
utils.py 90.90% <50.00%> (+0.21%) ⬆️
jobs.py 82.60% <75.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d60b5...574f4ba. Read the comment docs.

@zhaofeng-shu33 zhaofeng-shu33 changed the title [WIP]add deploy instructions add deploy instructions Mar 9, 2020
@lovepoem lovepoem merged commit 665ad36 into wuhan2020:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants