Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeouts limitation #530

Merged
merged 7 commits into from
Aug 6, 2020
Merged

Remove timeouts limitation #530

merged 7 commits into from
Aug 6, 2020

Conversation

KarolFrankiewicz
Copy link
Collaborator

This change removes max timeout limitation for login and waiting for elements.

Description

  • 10s max timeout for login is removed
  • 15s max timeout for waiting for WebElements is removed from modifiers
  • default timeout for login modifier is changed from 1s to 5s as documentation stated
  • documentation is updated to reflect changes

Motivation and Context

Required in #99

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@tMaxx tMaxx merged commit d352832 into master Aug 6, 2020
@tMaxx tMaxx deleted the remove-timeouts-limitation branch August 6, 2020 14:09
@annabudziszewska
Copy link
Collaborator

Tested and accepted
Version: 3.3.1.SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants