Remove handling unescaped URLs in suites #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible that after this change some suites won't work? If yes we could add some upgrade notes, otherwise don't care :D |
plutasnyy
approved these changes
Oct 15, 2019
dzuma
reviewed
Nov 12, 2019
| @Test(expected = ParseException.class) | ||
| public void testParse_withUnescapedUrls_expectParseException() throws Exception { | ||
| URL resourceURL = getClass().getResource("/testSuiteWithUnescapedUrls.xml"); | ||
| File testSuitFile = new File(resourceURL.toURI()); |
This was referenced Nov 15, 2019
|
Tested and accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed escaping URLs in suite XMLs.
As a result, suite file has to be a valid XML file to be successfully processed.
Description
This change removes additional escaping of URLs present in suites. Current behaviour expects all URLs to be unescaped and thus suite files are often invalid XMLs. Escaping URLs on your own leads to bugs described in #441.
By enforcing escaped URLs we make sure all suite files are valid XML files and prevent confusion regarding this topic. In case where there are unescaped URLs in a suite file, there will be an according error displayed, e.g:
which make it easy to fix all incorrect files.
Motivation and Context
This is a second approach to a bug described in #441.
Handling both escaped and unescaped URLs was implemented in #460, however it's been discussed that it may not be the best solution.
Upgrade notes (if appropriate)
Migrating to the version with this feature could require updating project's suite files to ensure that all URLs are properly escaped.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.