Generating correct correlationId when suite name is overridden #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wblachowski
changed the title
tkaik
reviewed
Jan 2, 2019
| @@ -71,7 +71,7 @@ public TestSuiteRun(TestSuiteRun testSuiteRun, String name, String domain, List< | |||
| this.company = testSuiteRun.getCompany(); | |||
| this.project = testSuiteRun.getProject(); | |||
| this.domain = domain; | |||
| this.correlationId = testSuiteRun.getCorrelationId(); | |||
| this.correlationId = CorrelationIdGenerator.generateCorrelationId(company, project, name); | |||
There was a problem hiding this comment.
It looks like this class has 2 constructors and now the 2nd constructor could use the 1st one to reduce the amount of code, what do you think? E.g. 2nd constructors could be changed to:
public TestSuiteRun(TestSuiteRun testSuiteRun, String name, String domain, List<TestRun> tests) {
this(name, testSuiteRun.getCompany(), testSuiteRun.getProject(), domain, tests);
}
There was a problem hiding this comment.
Great suggestion, it seems like a reasonable thing to do.
|
Can you add some unit tests for TestSuiteRun or SuiteExecutor (see which fits better) which test if correlation ID is correct when the suite name is overriden? Just to make sure that noone will break this again accidentally when doing some refactoring :) |
tkaik
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed generating correlationId with suite name overridden in command line. For details see #440.
Description
CorrelationId now contains overridden suite name instead of the value from XML file.
Motivation and Context
Closes #440
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.