Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix - side panel conditional tests presentation #399

Merged
merged 5 commits into from
Oct 23, 2018

Conversation

ernestosiak
Copy link
Contributor

Description

Fixed issue with side panel and conditional tests - all urls for test passed conditionally were presented as conditional, even if some of them passed normally

Motivation and Context

Issue 398

Screenshots:

Before

conditional-tests

After

conditional-tests-fixed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tkaik tkaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

By the way, this is a regular bug fix that will be released in future AET version - AFAIK a "hot fix" means that the fix will be applied (e.g. as a patch) to some already released version, which is not the case here - please use bugfix/xx-yy branch naming convention in future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants