Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#379] Exclude elements position calculated with partial screenshot offset #380

Merged
merged 2 commits into from
Oct 8, 2018
Merged

[#379] Exclude elements position calculated with partial screenshot offset #380

merged 2 commits into from
Oct 8, 2018

Conversation

tkaik
Copy link
Contributor

@tkaik tkaik commented Oct 5, 2018

Description

Exclude elements position calculated with partial screenshot offset

Motivation and Context

See #379

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

malaskowski
malaskowski approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@malaskowski malaskowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, quick fix. Don't forget about updating changelog.
Fixes #379

@tkaik tkaik merged commit b09d14d into master Oct 8, 2018
@tkaik tkaik deleted the bugfix/partial-screen-with-exclude branch October 8, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malaskowski malaskowski malaskowski approved these changes

@PiteroS678 PiteroS678 Awaiting requested review from PiteroS678

@plutasnyy plutasnyy Awaiting requested review from plutasnyy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkaik @malaskowski