updated osgi annotatation in jobs #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malaskowski
suggested changes
Aug 8, 2018
| @Component | ||
| @Service(ExternalSnippetHttpClient.class) | ||
| @Component(service = ExternalSnippetHttpClient.class) | ||
| @Designate(ocd = ExternalSnippetHttpClientConf.class) | ||
| public class ExternalSnippetHttpClient { | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(ExternalSnippetHttpClient.class); | ||
|
|
||
| private static final long DEFAULT_CONNECTION_TTL = 60L; |
There was a problem hiding this comment.
Those values were moved to ExternalSnippetHttpClientConf so you probably can remove it from here.
| @@ -35,6 +35,18 @@ | |||
|
|
|||
| <dependencies> | |||
| <!-- project --> | |||
| <dependency> | |||
There was a problem hiding this comment.
You may get rid of
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.scr.annotations</artifactId>
</dependency>and
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.commons.osgi</artifactId>
</dependency>
malaskowski
approved these changes
Aug 9, 2018
tkaik
reviewed
Aug 9, 2018
| name = SOURCE_COLLECTOR_TIMEOUT_VALUE, | ||
| description = "Timeout value for source collector [ms]", | ||
| type = AttributeType.INTEGER) | ||
| int timeoutValue() default DEFAULT_TIMEOUT; |
There was a problem hiding this comment.
With new @AttributeDefinition annotation, the name property is just a human-readable name (i.e. label for the property) - the property name itself is identified by the method name (timeoutValue). So now the method names should be equal to the value of name property on the old @Property annotations - otherwise we'll need to change property names in all karaf configuration files for this component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Felix annotations to OSGi in Jobs module
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.