New virtualization tool set (and new aet-cookbook version) #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
# Conflicts (resolved): # CHANGELOG.md # documentation/src/main/wiki/AETIn10Minutes.md # documentation/src/main/wiki/BasicSetup.md # vagrant/README.md
…le plugin from Maven
tkaik
reviewed
Aug 30, 2018
vagrant/Vagrantfile
Outdated
| @@ -96,7 +96,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| | |||
| } | |||
| } | |||
| chef.run_list = [ | |||
| "recipe[aet::_develop]", | |||
| # "recipe[aet::_develop]", | |||
There was a problem hiding this comment.
Thank you for this PR @wiiitek :)
I think we should use aet::_develop by default on Vagrant - it creates developer user which allows us to easily upload AET to Vagrant with maven using developer/developer credentials, as instructed in AET in 10 minutes
There was a problem hiding this comment.
You're right! This change was to test the use case described in wttech/aet-cookbook#30 (comment). I will revert this change. We should probably do a release for the aet-cookbook (version 5.0.0). What do you think?
tkaik
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade for our virtualization tools to:
Description
Updates made fr cookbook are on separate branch. This branch is specified in
Berksfile.When we are ready to merge (tests on different environments for new AET 10 minut setup) we would need to release new aet-cookbook version.
Motivation and Context
New Virtualbox and Chef will allow us to make progress into Windows environments more easily.
And we also don't want to use some old, non-supported versions (VirtualBox 5.1.x is no longer supported!).
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.