Feature/winter edition #238
Conversation
jakublamprecht
requested review from
mateuszluczak,
wiiitek,
edworczak and
michaldziubek
| @@ -26,6 +26,7 @@ require.config({ | |||
| 'angularAMD': '../assets/libs/angularAMD/angularAMD', | |||
| 'lodash': '../assets/libs/lodash/dist/lodash', | |||
| 'angular-bootstrap': '../assets/libs/angular-bootstrap/ui-bootstrap-tpls', | |||
| 'snowfall': '../assets/libs/snowfall/snowfall.min', | |||
There was a problem hiding this comment.
Maybe there's a better way to include this that I didn't think about?
| </div> | ||
| <div ng-if="test.getStatus() == 'rebased'"> | ||
| <i class="fas fa-cloud-upload-alt"></i> | ||
| <i class="fas {{theme.statusClasses[test.getStatus()]}}"></i> |
There was a problem hiding this comment.
Those elements are required, so that when a case gets accepted/rejected the icon is redrawn - simply adding an element with {{theme.statusClasses[test.getStatus()]}} won't work, since the italic tags are replaced with svg tags by fontawesome.
| } | ||
| } | ||
|
|
||
| function isInDateRange(today, eventDate, dayMargin) { |
There was a problem hiding this comment.
I was thinking about renaming the function to contain word near instead of range.
Checking if date is in range would expect arguments such as: date and range.
We are doing it slightly different. ->Would it be easier to read after such change?
| @@ -0,0 +1,61 @@ | |||
| /* | |||
There was a problem hiding this comment.
the folder report/src/main/webapp/app/components is the old one and not realy in sync with John Papa guide about folders for code. let's move this directive to some folder with the functional-like name.
we can create new folder below .../app called themes.
| @@ -28,7 +28,7 @@ | |||
| <script defer src="assets/icons/fontawesome-all.js"></script> | |||
| </head> | |||
|
|
|||
| <body aet-hide-popovers aet-keyboard-shortcuts aet-sidepanel ng-class="{ 'menu-expanded': sidebarExpanded }"> | |||
| <body aet-hide-popovers aet-keyboard-shortcuts aet-sidepanel aet-winter-edition ng-class="{ 'menu-expanded': sidebarExpanded }"> | |||
There was a problem hiding this comment.
is this CSS class needed? why? Maybe it should be only added in December ?
Those changes add winter theme to AETs that is automatically triggered two weeks before Christmas and is turned off two weeks after.
Description
Changed mechanism of adding classes of status icons. Added directive that triggers winter theme, changes logo and makes snow fall. Also updated some markup which could be simplified with the new way of adding icon classes.
Motivation and Context
It gives AET reports appropriate look and feel during winter time which can possibly boost users mood :)
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.