-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note tooltip new #229
Note tooltip new #229
Conversation
Conflicts (resolved): CHANGELOG.md report/src/main/webapp/assets/css/main.css
@@ -235,6 +235,6 @@ | |||
display: inline-block; | |||
} | |||
|
|||
.preformatted { | |||
font-family: monospace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is back in css now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify if no visual changes occurs due to the preformatted class styles removal.
@@ -39,6 +39,18 @@ | |||
} | |||
} | |||
|
|||
&-footer_flex { | |||
& { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this '&' necessary?
@@ -39,6 +39,18 @@ | |||
} | |||
} | |||
|
|||
&-footer_flex { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could move those styles to &-footer and inside it just write '&_flex' ?
} | ||
|
||
button + button { | ||
margin-right: 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is similar styling above in &-footer. Should these buttons have different styling based on whether they're in footer or footer_flex class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to add modal-footer_flex class to all popups, but there is one in report.html, which I couldn't get on the site. I left the styling (button + button) until someone can tell when this popup occurs.
@@ -235,6 +235,6 @@ | |||
display: inline-block; | |||
} | |||
|
|||
.preformatted { | |||
font-family: monospace; | |||
.popover-content > p { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's toolbar file and this style is pretty global, maybe it should be moved to main.scss?
Description
Removed empty space on popover when there is no comment.
Provided different logic and icons for comment and when there is no comment.
Introduced Font Awesome.
Improved buttons UX in editing comments.
I hereby agree to the terms of the AET Contributor License Agreement.