-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selenium upgraded to 3.8.1, guava upgraded to 23.6-jre #209
Changes from 1 commit
7c35df6
a3fafb4
e25c63f
c68fcec
a3a645a
e20525b
4e9df39
efe5310
9e49601
b162547
a5435b8
eef8fe8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
package com.cognifide.aet.cleaner.processors.filters; | ||
|
||
import com.cognifide.aet.vs.DBKey; | ||
import com.google.common.base.Objects; | ||
import com.google.common.base.MoreObjects; | ||
import com.google.common.base.Predicate; | ||
import org.apache.commons.lang3.StringUtils; | ||
|
||
|
@@ -35,6 +35,11 @@ public boolean apply(DBKey dbKey) { | |
return companyMatches(dbKey) && projectMatches(dbKey); | ||
} | ||
|
||
@Override | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. WE could use default implementation from the What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good point, fixed |
||
public boolean test(DBKey dbKey) { | ||
return apply(dbKey); | ||
} | ||
|
||
private boolean projectMatches(DBKey dbKey) { | ||
return StringUtils.isBlank(projectFilter) || dbKey.getProject().equals(projectFilter); | ||
} | ||
|
@@ -46,7 +51,7 @@ private boolean companyMatches(DBKey dbKey) { | |
|
||
@Override | ||
public String toString() { | ||
return Objects.toStringHelper(this) | ||
return MoreObjects.toStringHelper(this) | ||
.add("companyFilter", companyFilter) | ||
.add("projectFilter", projectFilter) | ||
.toString(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's upgrade guava also in
aet-features.xml
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/osgi-dependencies/aet-features.xml is recently added to gitignore. Is this expected? That's why my change is not in this PR.