-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expression support to endpoint definition attributes for handling endpoints in the HTTP connector. #2238
Open
chathuranga-jayanath-99
wants to merge
28
commits into
wso2:master
Choose a base branch
from
chathuranga-jayanath-99:integrate-new-expressions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json representation change
…pend state properties change
…out state properties change
Please squash these commits to a single one |
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
chanikag
reviewed
Nov 26, 2024
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Nov 26, 2024
modules/core/src/main/java/org/apache/synapse/endpoints/Endpoint.java
Outdated
Show resolved
Hide resolved
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 6, 2024
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 6, 2024
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 6, 2024
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 6, 2024
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Show resolved
Hide resolved
arunans23
reviewed
Dec 6, 2024
...core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionSerializer.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 6, 2024
...core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionSerializer.java
Outdated
Show resolved
Hide resolved
chathuranga-jayanath-99
force-pushed
the
integrate-new-expressions
branch
from
December 10, 2024 08:34
ffb50b7
to
2492a4e
Compare
chathuranga-jayanath-99
changed the title
Add support for expressions in endpoint definition attributes.
Add expression support to endpoint definition attributes for handling endpoints in the HTTP connector.
Dec 10, 2024
arunans23
reviewed
Dec 10, 2024
modules/core/src/main/java/org/apache/synapse/config/SynapseConfigUtils.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 10, 2024
modules/core/src/main/java/org/apache/synapse/config/SynapseConfigUtils.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 10, 2024
modules/core/src/test/java/org/apache/synapse/endpoints/HttpEndpointTest.java
Outdated
Show resolved
Hide resolved
arunans23
reviewed
Dec 10, 2024
...es/core/src/main/java/org/apache/synapse/config/xml/endpoints/EndpointDefinitionFactory.java
Outdated
Show resolved
Hide resolved
chathuranga-jayanath-99
force-pushed
the
integrate-new-expressions
branch
from
December 10, 2024 15:51
2492a4e
to
e79f395
Compare
Shall we explore whether we can resolve the values at the first request and use them for consecutive requests? Also lets try to do it for HTTP Endpoint only so that we do not have to modify the behaviour of other endpoint types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The HTTP connector uses the following format for maintaining endpoint definitions. To support this format, expression support for endpoint definition attributes is required. This PR introduces the necessary changes to enable this support for the use of HTTP connector. Note that expression support for
timeout-duration
is already available.