Improve log mediator to support string templating #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanojPunchihewa
force-pushed
the
log-mediator
branch
from
cd28c00 to
9b66249
Compare
modules/core/src/main/java/org/apache/synapse/util/InlineExpressionUtil.java
Outdated
Show resolved
Hide resolved
| // Extract the expression inside ${...} | ||
| String placeholder = matcher.group(1); | ||
| SynapseExpression expression = new SynapseExpression(placeholder); | ||
| String replacement = expression.stringValueOf(synCtx); |
There was a problem hiding this comment.
if the stringValueOf fails we get the value "unknown" should we print a warn log outside the while loop saying processed template might have an incorrect result since evaluation of some expressions failed.
There was a problem hiding this comment.
We cannot distinguish the unknown at the mediator level. We may need to print the warn log at the evaluation.
SanojPunchihewa
force-pushed
the
log-mediator
branch
2 times, most recently
from
082f1bf to
c1e4644
Compare
| @@ -288,6 +302,16 @@ public void setCategory(int category) { | |||
| } | |||
| } | |||
|
|
|||
| public String getMessageTemplate() { | |||
|
|
|||
There was a problem hiding this comment.
Why an additional new line?
There was a problem hiding this comment.
It's added by the wso2_code_style for idea.
| } | ||
|
|
||
| public void setMessageTemplate(String messageTemplate) { | ||
|
|
SanojPunchihewa
force-pushed
the
log-mediator
branch
from
c1e4644 to
01b0af9
Compare
SanojPunchihewa
force-pushed
the
log-mediator
branch
from
01b0af9 to
2463b2c
Compare
GDLMadushanka
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the current log mediator, the user needs to add a property and use XPATH concatenations to define a log message. With this improvement, the user can define a string template for the log message. In addition to the log message, the user can add additional properties to be logged.
To maintain backward compatibility when the user has set a
level, the message will be printed in addition to the content printed according tolevel