Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Consent manager issues in CDS TK #27

Merged
merged 20 commits into from
Nov 21, 2024

Conversation

anjuchamantha
Copy link
Contributor

@anjuchamantha anjuchamantha commented Oct 29, 2024

Fix consent manager issues

This PR fixes multiple issues in consent manager portal.

Related Issues

Applicable Labels: OB3 Accelerator, OB3 CDS Toolkit


Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

@anjuchamantha anjuchamantha added the Ready-to-Build Adding this label will trigger a new build job. label Oct 29, 2024
@anjuchamantha anjuchamantha added Ready-to-Build Adding this label will trigger a new build job. and removed Ready-to-Build Adding this label will trigger a new build job. labels Nov 11, 2024
@anjuchamantha anjuchamantha added Ready-to-Build Adding this label will trigger a new build job. and removed Ready-to-Build Adding this label will trigger a new build job. labels Nov 11, 2024
@anjuchamantha anjuchamantha changed the title [WIP] Fix Consent manager issues in CDS TK Fix Consent manager issues in CDS TK Nov 11, 2024
@anjuchamantha anjuchamantha changed the title Fix Consent manager issues in CDS TK [WIP] Fix Consent manager issues in CDS TK Nov 11, 2024
@anjuchamantha anjuchamantha changed the title [WIP] Fix Consent manager issues in CDS TK Fix Consent manager issues in CDS TK Nov 11, 2024
"successfully. %s", e.getMessage()));
// revoke access tokens if the user is not null. User can be null if the consent is revoked by a user with
// CustomerCareOfficer role in consent manager.
if (userId != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we revoking the tokens in CustomerCareOfficer scenario?

@imesh94 imesh94 added Ready-to-Build Adding this label will trigger a new build job. and removed Ready-to-Build Adding this label will trigger a new build job. labels Nov 20, 2024
@imesh94 imesh94 merged commit 60859bd into wso2:main Nov 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Build Adding this label will trigger a new build job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants