Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes done for introducing a gateway proxy to infosec endpoints #25

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Revert changes done for introducing a gateway proxy to infosec endpoints #25

merged 11 commits into from
Oct 28, 2024

Conversation

imesh94
Copy link
Contributor

@imesh94 imesh94 commented Oct 27, 2024

Revert changes done to introduce gateway proxy to infosec endpoints

Proxy changes were introduced by the PR https://github.com/wso2-support/ob-compliance-toolkit-cds/pull/137. These changes are reverted because issues related to infosec data publishing from IS are resolved.

Issue link: required

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

@aka4rKO
Copy link
Contributor

aka4rKO commented Oct 27, 2024

@imesh94 lets also remove the skip_list.apis config from the APIM toml

@aka4rKO aka4rKO added the Ready-to-Build Adding this label will trigger a new build job. label Oct 27, 2024
@imesh94
Copy link
Contributor Author

imesh94 commented Oct 27, 2024

@imesh94 lets also remove the skip_list.apis config from the APIM toml

Removed

@imesh94 imesh94 added Ready-to-Build Adding this label will trigger a new build job. and removed Ready-to-Build Adding this label will trigger a new build job. labels Oct 27, 2024
anjuchamantha
anjuchamantha previously approved these changes Oct 28, 2024
View reviewed changes
aka4rKO
aka4rKO previously approved these changes Oct 28, 2024
View reviewed changes
@anjuchamantha
Copy link
Contributor

@imesh94 shall we resolve the conflicts

@imesh94 imesh94 dismissed stale reviews from aka4rKO and anjuchamantha via f5a8866 October 28, 2024 09:12
@imesh94 imesh94 added Ready-to-Build Adding this label will trigger a new build job. and removed Ready-to-Build Adding this label will trigger a new build job. labels Oct 28, 2024
@anjuchamantha anjuchamantha added Ready-to-Build Adding this label will trigger a new build job. and removed Ready-to-Build Adding this label will trigger a new build job. labels Oct 28, 2024
@imesh94 imesh94 added Ready-to-Build Adding this label will trigger a new build job. and removed Ready-to-Build Adding this label will trigger a new build job. labels Oct 28, 2024
@anjuchamantha anjuchamantha requested a review from aka4rKO October 28, 2024 09:30
@aka4rKO aka4rKO merged commit 47641cd into wso2:main Oct 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malshaniS malshaniS malshaniS left review comments

@anjuchamantha anjuchamantha anjuchamantha approved these changes

@aka4rKO aka4rKO aka4rKO approved these changes

Assignees
No one assigned
Labels
Ready-to-Build Adding this label will trigger a new build job.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imesh94 @aka4rKO @anjuchamantha @malshaniS