Add keepalive configs as templated strings and modify their values #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| keepalive_probes: 3 | ||
| keepalive_time: 300 | ||
| keepalive_interval: 30 | ||
| keepalive_probes: '${KEEPALIVE_PROBES}' |
There was a problem hiding this comment.
Shall we prefix ADAPTER to make these config more specific?
Suggested change
| keepalive_probes: '${KEEPALIVE_PROBES}' | |
| keepalive_probes: '${ADAPTER_KEEPALIVE_PROBES}' |
There was a problem hiding this comment.
I guess we can keep this as it is and use it in all places. Hence +1
renuka-fernando
previously approved these changes
Nov 28, 2024
mevan-karu
reviewed
Nov 28, 2024
renuka-fernando
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Lower the 5-minute interval to check for liveness of adapter after establishing a connection to it to 1 minute. This would allow for faster detection when the local adapter goes down and enable faster switching to another replica. Additionally, by making these values dynamically configurable, we can adjust them as and when needed in the future.
Issues
Fixes https://github.com/wso2-enterprise/choreo/issues/32445
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge