-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove existing API key impl and replace it with new Choreo API key impl #3608
Conversation
@@ -46,7 +46,6 @@ | |||
<class name="org.wso2.choreo.connect.tests.testcases.standalone.endpoints.BackendSecurityTestCase"/> | |||
<class name="org.wso2.choreo.connect.tests.testcases.standalone.jwtValidator.JwtTestCase"/> | |||
<class name="org.wso2.choreo.connect.tests.testcases.standalone.jwtValidator.ScopeTest"/> | |||
<class name="org.wso2.choreo.connect.tests.testcases.standalone.jwtValidator.InternalKeyTestCase"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot remove this testcase as it is a legitimate one, (which we use to test testKey in current choreo context)
...nforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/APIKeyAuthenticator.java
Outdated
Show resolved
Hide resolved
...nforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/APIKeyAuthenticator.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/wso2/choreo/connect/tests/testcases/withapim/InternalKeyHeaderTestCase.java
Show resolved
Hide resolved
.../org/wso2/choreo/connect/tests/testcases/withapim/apikey/APIKeyAppLevelThrottleTestCase.java
Outdated
Show resolved
Hide resolved
...t/java/org/wso2/choreo/connect/tests/testcases/withapim/apikey/APIKeyBlockedAPITestCase.java
Outdated
Show resolved
Hide resolved
.../org/wso2/choreo/connect/tests/testcases/withapim/apikey/APIKeySubLevelThrottleTestCase.java
Outdated
Show resolved
Hide resolved
...on/src/test/java/org/wso2/choreo/connect/tests/testcases/withapim/apikey/APIKeyTestCase.java
Outdated
Show resolved
Hide resolved
.../java/org/wso2/choreo/connect/tests/testcases/withapim/apikey/InternalKeyHeaderTestCase.java
Show resolved
Hide resolved
...on/src/test/java/org/wso2/choreo/connect/tests/testcases/withapim/apikey/APIKeyTestCase.java
Outdated
Show resolved
Hide resolved
[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.11 |
[succeeded] : dev-deployment-v2 : 20241029.11 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.11 |
[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.12 |
[] : dev-deployment-v2 : 20241029.12 |
[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.12 |
[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241029.10 |
[failed] Controlplane cluster : stage-deployment-v2 : 20241029.10 |
[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241029.10 |
[failed] Controlplane cluster : stage-deployment-v2 : 20241029.10 |
[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241029.13 |
[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241029.13 |
[] Controlplane cluster : stage-deployment-v2 : 20241029.13 |
[] Controlplane cluster : prod-deployment-v2 : 20241031.2 |
[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241031.2 |
Purpose
This PR removes the existing API Key impl and replaces it with the new ChoreoAPIKeyAuthenticator impl.
Issues
Fixes #
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge