Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing API key impl and replace it with new Choreo API key impl #3608

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

mevan-karu
Copy link

Purpose

This PR removes the existing API Key impl and replaces it with the new ChoreoAPIKeyAuthenticator impl.

Issues

Fixes #

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Not Tested


Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@mevan-karu mevan-karu changed the title Remove existing API key impl and replace it with new API key impl Remove existing API key impl and replace it with new Choreo API key impl Oct 25, 2024
@@ -46,7 +46,6 @@
<class name="org.wso2.choreo.connect.tests.testcases.standalone.endpoints.BackendSecurityTestCase"/>
<class name="org.wso2.choreo.connect.tests.testcases.standalone.jwtValidator.JwtTestCase"/>
<class name="org.wso2.choreo.connect.tests.testcases.standalone.jwtValidator.ScopeTest"/>
<class name="org.wso2.choreo.connect.tests.testcases.standalone.jwtValidator.InternalKeyTestCase"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot remove this testcase as it is a legitimate one, (which we use to test testKey in current choreo context)

@VirajSalaka VirajSalaka merged commit fb43b0d into wso2:choreo Oct 29, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.11

@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20241029.11

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.11

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.12

@choreo-cicd
Copy link

[] : dev-deployment-v2 : 20241029.12

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.12

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241029.10

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20241029.10

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241029.10

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20241029.10

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241029.13

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241029.13

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20241029.13

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20241031.2

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241031.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants