Skip to content

Commit

Permalink
Merge pull request #3737 from malakaganga/fix_node_resolver
Browse files Browse the repository at this point in the history
Remove redundant logic after imp for coordination
  • Loading branch information
malakaganga authored Oct 25, 2024
2 parents 1338d60 + 781124f commit 018598e
Showing 1 changed file with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ public void memberAdded(NodeDetail nodeDetail) {
LOG.error("Exception occurred while resolving un assigned tasks upon member addition " + nodeDetail
.getNodeId(), e);
}
} else if (clusterCoordinator.getThisNodeId().equals(nodeDetail.getNodeId())
&& isMemberRejoinedAfterUnresponsiveness()) {
// This node became unresponsive and rejoined the cluster hence removing all tasks assigned to this node
// then start the scheduler again after cleaning the locally running tasks.
becameUnresponsive(nodeDetail.getNodeId());
reJoined(nodeDetail.getNodeId(), null);
}
}

Expand Down Expand Up @@ -134,15 +128,6 @@ public void becameUnresponsive(String nodeId) {
}
}

/**
* Check whether the member has rejoined after being unresponsive.
*
* @return true if the member has rejoined after being unresponsive, false otherwise
*/
public boolean isMemberRejoinedAfterUnresponsiveness() {
return taskManager.getLocallyRunningCoordinatedTasks().size() > 0;
}


@Override
public void reJoined(String nodeId, RDBMSMemberEventCallBack callBack) {
Expand Down

0 comments on commit 018598e

Please sign in to comment.