Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.0] Import Export CLI - PR 4 #7

Merged
merged 39 commits into from
Dec 7, 2017
Merged

[3.0.0] Import Export CLI - PR 4 #7

merged 39 commits into from
Dec 7, 2017

Conversation

menuka94
Copy link
Contributor

@menuka94 menuka94 commented Nov 25, 2017

Purpose

Update tests to reach 70% line coverage
Additional Functionality
Enhancements
Bug fixes

Related PRs

#1 #2 #3

Test environment

Go 1.8.x
Glide

Use it when the backendis implemented
Use placeholders instead of concatentation
Make a copy of main_config.yaml inside 'cmd'
update README.md and CONTRIBUTING.md
For import-api, export-api, and list apis
Total test coverage at 66.4%
test covereage > 70%
@menuka94 menuka94 closed this Nov 25, 2017
@menuka94
Copy link
Contributor Author

Will resolve conflicts and reopen.

@menuka94 menuka94 reopened this Nov 25, 2017
@menuka94 menuka94 closed this Nov 25, 2017
and resolve merge conflicts
@menuka94 menuka94 reopened this Nov 25, 2017
@menuka94
Copy link
Contributor Author

Merge conflicts were due to a change of author's email in my local git environment. All fixed!

@menuka94 menuka94 changed the title [3.0.0] - CLI for Importing and Exporting APIs - Increase test coverage to more than 70% [3.0.0] Import Export CLI - PR 4 Dec 5, 2017
"https://localhost/publisher",
"http://localhost/register",
"http://localhost/token",
}
utils.WriteConfigFile(mainConfig, utils.MainConfigFilePath)
utils.WriteConfigFile(mainConfig, utils.SampleMainConfigFilePath)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #11 for 3.0.0

@@ -84,7 +84,8 @@ fi
#platforms="linux/amd64/linux/x64"
#platforms="darwin/amd64/macosx/x64"
if [ "${full_build}" == "true" ]; then
echo "Building "$'\e[1m'"${filename^^}:${build_version}"$'\e[0m'" for all platforms..."
# following line causes an error in MacOS
# echo "Building "$'\e[1m'"${filename^^}:${build_version}"$'\e[0m'" for all platforms..."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #10 for 3.0.0

</ul>
<hr>
<ul>
<li><h3 id="adding-environments">Adding Environments</h3>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #13 for 3.0.0


Created packages will be available at `build/target` directory

- ### Running
Extract the compressed archive generated to a desired location.

Then execute `import-export-cli/apimcli` to start the application.
Then execute `./apimcli` to start the application. (Being inside `product-apim-tooling/import-export-cli`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #12 for 3.0.0

@tharindu1st tharindu1st merged commit 64d27ea into wso2:master Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants