fix(react): fix Select
label margin issues
#308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes several changes to the
Select
component and its related files in thepackages/react
directory. The changes focus on code cleanup, improving the component's functionality, and updating styles.Code Cleanup and Refactoring:
packages/react/src/components/Select/Select.stories.mdx
: Reorganized imports to ensure proper module paths and added aStack
component for layout purposes.packages/react/src/components/Select/Select.stories.mdx
: Simplified theTemplate
function and added an additionalSelect
component to demonstrate version selection. [1] [2]Component Enhancements:
packages/react/src/components/Select/Select.tsx
: Updated theInputLabelProps
to always shrink the label and added defaultsize
andvariant
properties for theSelect
component.packages/react/src/components/Select/Select.tsx
: Deprecated old class names in favor of new ones (OxygenSelectLabel-root
andOxygenSelect-root
) and added warnings for their removal in the next major release.Style Updates:
packages/react/src/components/Select/select.scss
: Removed outdated styles and added new styles for theOxygenSelect-root
class to fix layout issues.Related Issues
Select
component's label has some alignment issues when used statically #171Related PRs
Checklist
Security checks