[bug-fix] Fix roles retrieve issue in Group creation flow #7199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7199 +/- ##
=======================================
Coverage 32.02% 32.02%
=======================================
Files 41 41
Lines 893 893
Branches 220 204 -16
=======================================
Hits 286 286
- Misses 587 607 +20
+ Partials 20 0 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
|
|
||
| if (roleList?.length < 1) { | ||
| if (isFirstLevelOrganization()) { |
There was a problem hiding this comment.
What is the reason for removing this logic?
There was a problem hiding this comment.
This is no longer needed. Moving forward scim2 endpoint should be used. /organizations/${organizationId}/roles endpoint is not used as mentioned in the issue description.
| } = useGetRolesList( | ||
| 100, | ||
| null, | ||
| `audience.value ne ${consoleId}`, |
There was a problem hiding this comment.
Is it intentional to update this component's behaviour to work only for console application?
There was a problem hiding this comment.
The intention is to filter out console app roles. Please check the existing behavior of the roles listing.
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks