Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the idvp image URL from the API request body. #7101

Merged

Conversation

AfraHussaindeen
Copy link
Contributor

@AfraHussaindeen AfraHussaindeen commented Nov 8, 2024

Purpose

  • Remove the idvp image URL from the API request body.
  • Additionally add the onfido logo and updated the facebook logo.

UI view with the updated logos:
Screenshot 2024-12-05 at 10 13 09
Screenshot 2024-12-05 at 10 20 02
Screenshot 2024-12-05 at 10 20 24

Related Issues

Related PRs

Todo

  • Add the latest onfido logo. (Already made a request from onfido side)

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

JayaShakthi97
JayaShakthi97 previously approved these changes Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (9930f13) to head (a033918).
Report is 477 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7101   +/-   ##
=======================================
  Coverage   32.02%   32.02%           
=======================================
  Files          41       41           
  Lines         893      893           
  Branches      204      204           
=======================================
  Hits          286      286           
  Misses        607      607           
Flag Coverage Δ
@wso2is/core 32.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@AfraHussaindeen AfraHussaindeen merged commit bbf0cbc into wso2:master Dec 5, 2024
11 checks passed
@AfraHussaindeen AfraHussaindeen mentioned this pull request Dec 11, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants