Remove the implementation of showing the old QR code #6847
Conversation
Design Review
|
apps/myaccount/src/components/multi-factor-authentication/authenticators/totp-authenticator.tsx
Outdated
Show resolved
Hide resolved
| closeOnDimmerClick={ false } | ||
| dimmer="blurring" | ||
| > | ||
| <Modal.Content data-testid={ `${testId}-regenerate-confirm-modal-content` }> |
There was a problem hiding this comment.
refrain from using data-testid use data-componentid instead.
There was a problem hiding this comment.
check other places and remove data-testid
There was a problem hiding this comment.
This is a component we had earlier, not a new one. So it has already used testids and I think if we change them, a lot of e2e might break.
There was a problem hiding this comment.
better to add a data-componentid param then, keeping the data-testid, and create an issue to check the E2E on this
…enticators/totp-authenticator.tsx Co-authored-by: Achintha Isuru <[email protected]>
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
| </Message.Content> | ||
| </Message> | ||
| { | ||
| commonConfig.accountSecurityPage.mfa.totp.showRegenerateConfirmation |
There was a problem hiding this comment.
Let's remove the showRegenerateConfirmation from config files as well. With the improved UI this config won't be used.
After the unification the config is always set to
false. Therefore no point of keeping it at all.
| <Message className="display-flex" size="small" warning> | ||
| <Icon name="warning sign" color="orange" corner /> | ||
| <Message.Content className="tiny"> | ||
| { t(commonConfig.accountSecurityPage.mfa.totp.regenerateWarning) } |
There was a problem hiding this comment.
Check the possibility of removing regenerateWarning config as well. Seems the usage has been removed this PR.
|
This will be addressed via a different approach, hence closing the PR. |
Purpose
Previous UI
New UI
With the new suggested change, we’ll be using refresh icon to generate the new qr code and won’t be showing the old qr code now. This behaviour is similar to backup code generation as well.
Checklist
Security checks