Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🧹 UNIFICATION CLEANUP] Refactor admin.extensions.v1/components/application #6744

Merged
merged 10 commits into from
Aug 13, 2024
Merged

[🧹 UNIFICATION CLEANUP] Refactor admin.extensions.v1/components/application #6744

merged 10 commits into from
Aug 13, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Aug 9, 2024 •
edited
Loading

Purpose

  • Remove API resource v1 related extensions
  • Move Try It Application related logic to admin.applications.v1

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@brionmario brionmario force-pushed the code-cleanup-2024-extensions branch 2 times, most recently from 810f84a to 1e83340 Compare August 12, 2024 12:11
@brionmario brionmario changed the title Refactor admin.extensions.v1/components/application [🧹 UNIFICATION CLEANUP] Refactor admin.extensions.v1/components/application Aug 12, 2024
pavinduLakshan
pavinduLakshan reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add changeset as well.

features/admin.applications.v1/components/try-it/try-it-create-wizard.tsx
icon={ InformationIcon }
icon={ (
/* eslint-disable max-len */
<svg width="80" height="80" viewBox="0 0 512 512" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is hardcoding the icon here intentional?

Copy link
Member Author

@brionmario brionmario Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the icon and there's no point of maintaining this in the theme as a re-usable resource.
Ideally this should be migrated to the InfoModal in the react-components. Until then, lets inline.

Screenshot 2024-08-13 at 10 59 36

features/admin.applications.v1/constants/try-it-constants.ts Outdated
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com). All Rights Reserved.
* Copyright (c) 2020-2024, WSO2 LLC. (https://www.wso2.com).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2020-2024, WSO2 LLC. (https://www.wso2.com).
* Copyright (c) 2022-2024, WSO2 LLC. (https://www.wso2.com).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 208951d

features/admin.applications.v1/utils/get-try-it-client-id.ts Outdated
@@ -0,0 +1,38 @@
/**
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com).
* Copyright (c) 2024, WSO2 LLC. (https://www.wso2.com).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with f9ffd21

features/admin.roles.v2/models/policies.ts
/**
* No Policy.
*/
NO = "NONE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT?

Suggested change
NO = "NONE"
NONE = "NONE"

Copy link
Member Author

@brionmario brionmario Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an already existing model and seems like moving the file and renaming has messed up the Git history.

Hence, keeping this as it is.

pavinduLakshan

This comment was marked as duplicate.

Sign in to view

pavinduLakshan

This comment was marked as duplicate.

Sign in to view

@brionmario brionmario force-pushed the code-cleanup-2024-extensions branch from 208951d to 6ee056b Compare August 13, 2024 05:39
pavinduLakshan
pavinduLakshan previously approved these changes Aug 13, 2024
View reviewed changes
dasuni-30
dasuni-30 previously approved these changes Aug 13, 2024
View reviewed changes
@brionmario brionmario dismissed stale reviews from dasuni-30 and pavinduLakshan via 14e0437 August 13, 2024 05:55
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit a62b383 into wso2:master Aug 13, 2024
6 checks passed
@wso2-jenkins-bot wso2-jenkins-bot mentioned this pull request Aug 13, 2024
Merged
@brionmario brionmario mentioned this pull request Aug 13, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasuni-30 dasuni-30 dasuni-30 approved these changes

@pavinduLakshan pavinduLakshan pavinduLakshan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brionmario @wso2-jenkins-bot @dasuni-30 @pavinduLakshan