-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup identity-providers feature (Pt.1) #6457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayaShakthi97
force-pushed
the
post-unification-1
branch
from
June 26, 2024 09:58
e7388d3
to
f21470c
Compare
JayaShakthi97
changed the title
Clean identity-providers feature
Cleanup identity-providers feature
Jun 26, 2024
JayaShakthi97
changed the title
Cleanup identity-providers feature
Cleanup identity-providers feature (PART 1)
Jun 27, 2024
JayaShakthi97
changed the title
Cleanup identity-providers feature (PART 1)
Cleanup identity-providers feature (Pt. 1)
Jun 27, 2024
JayaShakthi97
changed the title
Cleanup identity-providers feature (Pt. 1)
Cleanup identity-providers feature (Pt.1)
Jun 27, 2024
brionmario
previously approved these changes
Jun 27, 2024
brionmario
reviewed
Jun 27, 2024
...lications.v1/components/settings/sign-on-methods/step-based-flow/add-authenticator-modal.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Jun 27, 2024
...dmin.applications.v1/components/settings/sign-on-methods/step-based-flow/step-based-flow.tsx
Outdated
Show resolved
Hide resolved
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
brionmario
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR partially cleans up the admin.identity-providers feature.
EditMultiFactorAuthenticator
to the admin.connections feature.identity-apps/features/admin.identity-providers.v1/components/edit-multi-factor-authenticator.tsx
Line 77 in 2165de8
AuthenticatorCreateWizardFactory
from admin.connections feature.identity-apps/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
Lines 27 to 29 in 2165de8
Related Issues
Related PRs
Checklist
Security checks