Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary removal of application revoke option #1876

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Temporary removal of application revoke option #1876

merged 1 commit into from
Mar 16, 2021

Conversation

ashans
Copy link
Contributor

@ashans ashans commented Mar 16, 2021

Purpose

Remove application revoke option as it does not properly disable the application from backend. The feature is disabled until proper backend support is provided for disabling application for all protocols: Resolves wso2/product-is#11453

Approach

Removed *Revoke button from application protocols page next to ClientId and removed the application status indicator as from current fix application disabling is avoided

2021-03-16_10-25
2021-03-16_10-25_1

@@ -561,6 +561,8 @@ export const InboundOIDCForm: FunctionComponent<InboundOIDCFormPropsInterface> =

/**
* Show Revoke confirmation.
* TODO - Currently revoke functionality is disabled until proper backend support is provided for disabling
* @link https://github.com/wso2-enterprise/asgardeo-product/issues/2668
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets create relevant issues in product-is and link here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f1f310d

@chamathns chamathns merged commit 9e73320 into wso2:master Mar 16, 2021
@mefarazath
Copy link
Contributor

Have we tracked the story to implement the revoke/disable application at application level instead of OAuth protocol level?

@chamathns
Copy link
Contributor

Have we tracked the story to implement the revoke/disable application at application level instead of OAuth protocol level?

Yes. It is tracked with wso2/product-is#11456.

wso2-jenkins-bot pushed a commit that referenced this pull request Apr 30, 2024
wso2-jenkins-bot pushed a commit that referenced this pull request Apr 30, 2024
wso2-jenkins-bot pushed a commit that referenced this pull request Apr 30, 2024
wso2-jenkins-bot pushed a commit that referenced this pull request Apr 30, 2024
wso2-jenkins-bot pushed a commit that referenced this pull request Apr 30, 2024
wso2-jenkins-bot pushed a commit that referenced this pull request Apr 30, 2024
wso2-jenkins-bot pushed a commit that referenced this pull request Apr 30, 2024
jathushan-r pushed a commit to jathushan-r/identity-apps that referenced this pull request May 5, 2024
jathushan-r pushed a commit to jathushan-r/identity-apps that referenced this pull request May 5, 2024
jathushan-r pushed a commit to jathushan-r/identity-apps that referenced this pull request May 5, 2024
jathushan-r pushed a commit to jathushan-r/identity-apps that referenced this pull request May 5, 2024
jathushan-r pushed a commit to jathushan-r/identity-apps that referenced this pull request May 5, 2024
jathushan-r pushed a commit to jathushan-r/identity-apps that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the revoke option in the application protocol section.
4 participants