Merge pull request #5767 from dasuni-30/fix/22700

Fix custom properties update issue for connections
wso2 · Mar 17, 2024 · 727bf84 · 727bf84
2 parents b924f32 + b9f5086
commit 727bf84
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/.changeset/tricky-pens-applaud.md b/.changeset/tricky-pens-applaud.md
@@ -0,0 +1,5 @@
+---
+"@wso2is/console": patch
+---
+
+Fix custom properties update issue in connections
diff --git a/...features/connections/components/edit/forms/components/common-pluggable-component-form.tsx b/...features/connections/components/edit/forms/components/common-pluggable-component-form.tsx
@@ -150,7 +150,7 @@ export const CommonPluggableComponentForm: FunctionComponent<CommonPluggableComp
         });
 
         const modifiedCustomProperties: any = !isEmpty(resolvedCustomProperties) ?
-            resolvedCustomProperties?.toString()?.split(",")?.map(
+            resolvedCustomProperties?.toString()?.split(", ")?.map(
                 (customProperty: string) => {
                     const keyValuePair: string[] = customProperty.split("=");
 
@@ -467,12 +467,6 @@ export const CommonPluggableComponentForm: FunctionComponent<CommonPluggableComp
                     return;
                 }
 
-                // Check whether the property already in dynamicValues?.properties.
-                if (dynamicValues?.properties?.find(
-                    (prop: CommonPluggableComponentPropertyInterface) => prop.key === property.key)) {
-                    return;
-                }
-
                 // Check whether the property is not in the metadata.
                 if (!metadata?.properties?.find(
                     (meta: CommonPluggableComponentMetaPropertyInterface) => meta.key === property.key)) {

diff --git a/apps/console/src/features/connections/components/edit/settings/authenticator-settings.tsx b/apps/console/src/features/connections/components/edit/settings/authenticator-settings.tsx
@@ -1000,9 +1000,6 @@ export const AuthenticatorSettings: FunctionComponent<IdentityProviderSettingsPr
                     mode={ AuthenticatorSettingsFormModes.EDIT }
                     authenticator={ authenticator }
                     metadata={ authenticator.meta }
-                    showCustomProperties={
-                        authenticator.id !== ConnectionManagementConstants.GITHUB_AUTHENTICATOR_ID
-                    }
                     initialValues={ authenticator.data }
                     onSubmit={ handleAuthenticatorConfigFormSubmit }
                     type={ authenticator.meta?.authenticatorId }