Add user approval APIs #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
....carbon.identity.api.user.approval/org.wso2.carbon.identity.api.user.approval.common/pom.xml
Outdated
Show resolved
Hide resolved
| <parent> | ||
| <artifactId>org.wso2.carbon.identity.api.user.approval</artifactId> | ||
| <groupId>org.wso2.carbon.identity.user.api</groupId> | ||
| <version>1.3.59-SNAPSHOT</version> |
There was a problem hiding this comment.
The artifact version might get increased when we are going to merge this PR. At that time, let's remember to update the version.
|
|
||
| </dependencies> | ||
|
|
||
| </project> |
There was a problem hiding this comment.
Add new line to the end of file.
...o2/carbon/identity/rest/api/user/approval/v1/core/factories/ApprovalEventServiceFactory.java
Show resolved
Hide resolved
| import org.wso2.carbon.identity.workflow.engine.ApprovalEventService; | ||
|
|
||
| public class ApprovalEventServiceFactory { | ||
| private static final ApprovalEventService SERVICE; |
There was a problem hiding this comment.
Add new line. Follow for the other classes also.
| @Override | ||
| public Response getApprovalTaskInfo(String taskId) { | ||
|
|
||
| // do some magic! |
There was a problem hiding this comment.
Suggested change
| // do some magic! |
...pproval.v1/src/gen/java/org/wso2/carbon/identity/rest/api/user/approval/v1/dto/StateDTO.java
Outdated
Show resolved
Hide resolved
...oval.v1/src/gen/java/org/wso2/carbon/identity/rest/api/user/approval/v1/dto/PropertyDTO.java
Outdated
Show resolved
Hide resolved
...approval/org.wso2.carbon.identity.rest.api.user.approval.v1/src/main/resources/approval.yaml
Outdated
Show resolved
Hide resolved
...approval/org.wso2.carbon.identity.rest.api.user.approval.v1/src/main/resources/approval.yaml
Outdated
Show resolved
Hide resolved
|
@SenuDyl Shall we update the PR description with the public git issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning