[Spring Cleanup] Remove Spring dependencies in user authorized apps API #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Authorized apps v1 
Authorized apps v2 
|
ThaminduR
reviewed
Jan 25, 2025
...so2/carbon/identity/rest/api/user/authorized/apps/v1/utils/AuthorizedAppsServicesHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 25, 2025
...so2/carbon/identity/rest/api/user/authorized/apps/v1/utils/AuthorizedAppsServicesHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 25, 2025
...bon/identity/rest/api/user/authorized/apps/v2/factories/AuthorizedAppsApiServiceFactory.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 25, 2025
...bon/identity/rest/api/user/authorized/apps/v2/factories/AuthorizedAppsApiServiceFactory.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 25, 2025
...wso2/carbon/identity/rest/api/user/authorized/apps/v2/factories/UserIdApiServiceFactory.java
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 25, 2025
...wso2/carbon/identity/rest/api/user/authorized/apps/v2/factories/UserIdApiServiceFactory.java
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 25, 2025
...so2/carbon/identity/rest/api/user/authorized/apps/v2/utils/AuthorizedAppsServicesHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 25, 2025
Comment on lines
+38
to
+39
| static final ApplicationManagementService SERVICE = (ApplicationManagementService) PrivilegedCarbonContext | ||
| .getThreadLocalCarbonContext().getOSGiService(ApplicationManagementService.class, null); |
There was a problem hiding this comment.
shouldn't these have the same null check as the realm service
There was a problem hiding this comment.
null check is being handled from here.
…rg.wso2.carbon.identity.rest.api.user.authorized.apps.v1/src/main/java/org/wso2/carbon/identity/rest/api/user/authorized/apps/v1/utils/AuthorizedAppsServicesHolder.java Co-authored-by: Thamindu R <[email protected]>
…rg.wso2.carbon.identity.rest.api.user.authorized.apps.v2/src/gen/java/org/wso2/carbon/identity/rest/api/user/authorized/apps/v2/factories/AuthorizedAppsApiServiceFactory.java Co-authored-by: Thamindu R <[email protected]>
…rg.wso2.carbon.identity.rest.api.user.authorized.apps.v2/src/gen/java/org/wso2/carbon/identity/rest/api/user/authorized/apps/v2/factories/AuthorizedAppsApiServiceFactory.java Co-authored-by: Thamindu R <[email protected]>
…rg.wso2.carbon.identity.rest.api.user.authorized.apps.v2/src/main/java/org/wso2/carbon/identity/rest/api/user/authorized/apps/v2/utils/AuthorizedAppsServicesHolder.java Co-authored-by: Thamindu R <[email protected]>
sadilchamishka
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issue(s)