Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spring Cleanup] Remove Spring dependencies in user authorized apps API #216

Open
wants to merge 1 commit into
base: feature-spring-cleanup
Choose a base branch
from
Open

[Spring Cleanup] Remove Spring dependencies in user authorized apps API #216

wants to merge 1 commit into from

Conversation

NipuniBhagya
Copy link

Purpose

This PR removes dependencies and usages of the Spring framework in the user authorized apps API.

Related Issue(s)

nilasini
nilasini reviewed Dec 10, 2024
View reviewed changes
...carbon/identity/rest/api/user/authorized/apps/v1/factories/AuthorizedAppsServiceFactory.java

}

private static class AuthorizedAppsServiceHolder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to adding sevice holder here? Can't we use the same approach used in [1]
[1] https://github.com/wso2/identity-api-user/pull/206/files#diff-148b635787c4b5c7ce0d1d77b45c189df0541aa5ac5a9ed4e5c093523b41b7e6R29-R57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilasini nilasini nilasini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NipuniBhagya @nilasini