add new approval service

wso2 · Jul 25, 2022 · 4553925 · 4553925
1 parent c0a8683
commit 4553925
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/...c/main/java/org/wso2/carbon/identity/rest/api/user/approval/v1/impl/MeApiServiceImpl.java b/...c/main/java/org/wso2/carbon/identity/rest/api/user/approval/v1/impl/MeApiServiceImpl.java
@@ -34,9 +34,8 @@ public class MeApiServiceImpl extends MeApiService {
 
     private ApprovalEventService approvalEventService;
     private UserApprovalService userApprovalService;
-    private static boolean simpleWorkflow;
     public static final String SIMPLE_WORKFLOW_ENGINE = "Workflow.SimpleWorkflow.Enable";
-    String enableSimpleWorkflowEngine = IdentityUtil.getProperty(SIMPLE_WORKFLOW_ENGINE);
+    private static boolean enableSimpleWorkflowEngine = Boolean.parseBoolean(IdentityUtil.getProperty(SIMPLE_WORKFLOW_ENGINE));
 
     public MeApiServiceImpl() {
 
@@ -53,10 +52,7 @@ public MeApiServiceImpl(ApprovalEventService approvalEventService, UserApprovalS
     @Override
     public Response getApprovalTaskInfo(String taskId) {
 
-        if (StringUtils.isNotBlank(enableSimpleWorkflowEngine)) {
-            simpleWorkflow = Boolean.parseBoolean(enableSimpleWorkflowEngine);
-        }
-        if (simpleWorkflow == true) {
+        if (enableSimpleWorkflowEngine) {
             return Response.ok().entity(approvalEventService.getTaskData(taskId)).build();
         }
         return Response.ok().entity(userApprovalService.getTaskData(taskId)).build();
@@ -65,10 +61,7 @@ public Response getApprovalTaskInfo(String taskId) {
     @Override
     public Response listApprovalTasksForLoggedInUser(Integer limit, Integer offset, List<String> status) {
 
-        if (StringUtils.isNotBlank(enableSimpleWorkflowEngine)) {
-            simpleWorkflow = Boolean.parseBoolean(enableSimpleWorkflowEngine);
-        }
-        if (simpleWorkflow == true) {
+        if (enableSimpleWorkflowEngine) {
             return Response.ok().entity(approvalEventService.listTasks(limit, offset, status)).build();
         }
         return Response.ok().entity(userApprovalService.listTasks(limit, offset, status)).build();
@@ -77,10 +70,7 @@ public Response listApprovalTasksForLoggedInUser(Integer limit, Integer offset,
     @Override
     public Response updateStateOfTask(String taskId, StateDTO nextState) {
 
-        if (StringUtils.isNotBlank(enableSimpleWorkflowEngine)) {
-            simpleWorkflow = Boolean.parseBoolean(enableSimpleWorkflowEngine);
-        }
-        if (simpleWorkflow == true) {
+        if (enableSimpleWorkflowEngine) {
             approvalEventService.updateStatus(taskId, nextState );
             return Response.ok().build();
         }