Add tags in the idp authenticator responses. #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thisara-Welmilla
force-pushed
the
add-tags-in-reponses
branch
3 times, most recently
from
ecb1b0c to
97fc457
Compare
Thisara-Welmilla
force-pushed
the
add-tags-in-reponses
branch
from
97fc457 to
e2c0b71
Compare
Thisara-Welmilla
force-pushed
the
add-tags-in-reponses
branch
from
e2c0b71 to
5fe52b8
Compare
| * FederatedAuthenticatorConfig. | ||
| * | ||
| * @param fedAuthConfigs Array of FederatedAuthenticatorConfig instances. | ||
| * @return List of FederatedAuthenticatorListItem instances. |
There was a problem hiding this comment.
Missing idpResourceId param
| */ | ||
| if (DefinedByType.USER == config.getDefinedByType()) { | ||
| return config.getTags(); | ||
|
|
There was a problem hiding this comment.
Remove this extra line
| if (federatedAuthenticatorConfig != null) { | ||
| return federatedAuthenticatorConfig.getTags(); | ||
| } | ||
| return new String[0]; |
There was a problem hiding this comment.
return ApplicationAuthenticatorService.getInstance()
.getFederatedAuthenticatorByName(config.getName())
.map(FederatedAuthenticatorConfig::getTags)
.orElse(new String[0]);
| @@ -435,6 +466,23 @@ private static void resolveEndpointConfiguration(FederatedAuthenticator authenti | |||
| } | |||
| } | |||
|
|
|||
| private static String[] resolveAuthenticatorTags(FederatedAuthenticatorConfig config) { | |||
There was a problem hiding this comment.
Is there a requirement to return the tags as an array ? Can't we return a List ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
tagsProperty in the API Response of User-Defined Federated Authenticators product-is#21998Following changes are added with this PR:
FederatedAuthenticatorConfigBuilderFactoryclass to build list ofFederatedAuthenticatorListItemwhere authenticators will be list with basic info.Integration tests: wso2/product-is#22002