Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue in idempotency validation for APIs without a payload #57

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fixed Issue in idempotency validation for APIs without a payload #57

merged 2 commits into from
Apr 26, 2024

Conversation

Ashi1993
Copy link
Contributor

Fixed issues identified in Idempotency QA testing

This PR contains the fixes for issues identified in Idempotency QA testing

Issue link: **

Doc Issue: **

Applicable Labels: OB 3.0.0

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. [ x Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

VimukthiRajapaksha
VimukthiRajapaksha reviewed Apr 25, 2024
View reviewed changes
...wso2/openbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidator.java
String errorMsg = String.format(IdempotencyConstants.ERROR_NO_CONSENT_DETAILS, consentId);
log.error(errorMsg);
throw new IdempotencyValidationException(errorMsg);
if (!IdempotencyConstants.EMPTY_OBJECT.equals(consentManageData.getPayload().toString())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this be null? consentManageData.getPayload()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is checked upfront in line 68

...wso2/openbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidator.java Outdated Show resolved Hide resolved
@aka4rKO aka4rKO merged commit a266b47 into wso2:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aka4rKO aka4rKO aka4rKO approved these changes

@hasithakn hasithakn hasithakn approved these changes

@VimukthiRajapaksha VimukthiRajapaksha VimukthiRajapaksha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashi1993 @VimukthiRajapaksha @hasithakn @aka4rKO