Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to Idempotency validation with extending capability #51

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Improvement to Idempotency validation with extending capability #51

merged 9 commits into from
Mar 26, 2024

Conversation

Ashi1993
Copy link
Contributor

Improvement to Idempotency validation with extending capability

This PR adds an improvement to idempotency validation including the extending capability

Issue link: #47

Doc Issue: wso2/docs-open-banking#881

Applicable Labels: OB 3.0.0

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. [ x Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

VimukthiRajapaksha
VimukthiRajapaksha reviewed Mar 25, 2024
View reviewed changes
...penbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidationUtils.java Outdated Show resolved Hide resolved
...penbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidationUtils.java Outdated Show resolved Hide resolved
...penbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidationUtils.java Show resolved Hide resolved
...penbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidationUtils.java Outdated Show resolved Hide resolved
...penbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidationUtils.java Outdated Show resolved Hide resolved
...penbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidationUtils.java Outdated Show resolved Hide resolved
...penbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidationUtils.java Outdated Show resolved Hide resolved
...wso2/openbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidator.java Outdated Show resolved Hide resolved
...wso2/openbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidator.java Outdated Show resolved Hide resolved
...wso2/openbanking/accelerator/consent/extensions/common/idempotency/IdempotencyValidator.java Outdated Show resolved Hide resolved
@VimukthiRajapaksha VimukthiRajapaksha merged commit 5e8c84e into wso2:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aka4rKO aka4rKO aka4rKO approved these changes

@imesh94 imesh94 imesh94 approved these changes

@RivinduM RivinduM RivinduM approved these changes

@VimukthiRajapaksha VimukthiRajapaksha VimukthiRajapaksha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ashi1993 @VimukthiRajapaksha @RivinduM @imesh94 @aka4rKO