Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues in Event Notification Implementation #33

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Fixing issues in Event Notification Implementation #33

merged 6 commits into from
Nov 17, 2023

Conversation

Ashi1993
Copy link
Contributor

@Ashi1993 Ashi1993 commented Nov 2, 2023 •
edited
Loading

Fixing issues in Event Notification Implementation

This PR contains the fixes for issues in Event Notification Implementation

Issue link: https://github.com/wso2-enterprise/financial-open-banking/issues/8320

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

@Ashi1993 @ChinthakaJ98
Update open-banking-accelerator/accelerators/ob-is/carbon-home/dbscri…
0fd00a0 
…pts/open-banking/event-notifications/oracle.sql

Co-authored-by: Chinthaka Jayatilake <[email protected]>
@hasithakn hasithakn merged commit a0494f7 into wso2:main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChinthakaJ98 ChinthakaJ98 ChinthakaJ98 approved these changes

@hasithakn hasithakn hasithakn approved these changes

@RivinduM RivinduM RivinduM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashi1993 @RivinduM @hasithakn @ChinthakaJ98