Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to get redirect_uri using par request_uri in OBIdentifierAuthenticator #25

Closed
wants to merge 4 commits into from

Conversation

imesh94
Copy link
Contributor

@imesh94 imesh94 commented Oct 2, 2023

Add support to get redirect_uri using par request_uri in OBIdentifierAuthenticator

This change is done to support the newly introduced AuthParameterFilter in IS-6.1 (ref mail: $Filtering the query params from default consent page redirection url) which consumes session data that is required by the OBIdentifierAuth flow in CDS. Although session data is added to the request by AuthParameterFilter, redirect_uri is not added since it resides in the par request object. A new method is added to get the redirect_uri by giving the request_uri which is available as a request parameter.

Issue link: https://github.com/wso2-enterprise/ob-compliance-toolkit-cds/issues/227

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)


Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Formatted code according to WSO2 code style.
  5. Migration scripts written (if applicable).

Secure Development Checklist

  1. Ran FindSecurityBugs plugin and verified report.
  2. Ran Dependency-check plugin and verified report for new dependencies added.
  3. Ran Dependency-check plugin and verified report for dependency version changes.
  4. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  5. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

@imesh94 imesh94 force-pushed the fix/opensource/identifier-auth-fix branch from 997e717 to c5a9985 Compare October 2, 2023 15:01
@imesh94 imesh94 changed the base branch from 3.0.0 to main August 15, 2024 09:56
@imesh94 imesh94 marked this pull request as draft August 15, 2024 10:00
@imesh94 imesh94 marked this pull request as ready for review August 15, 2024 10:00
@imesh94
Copy link
Contributor Author

imesh94 commented Aug 15, 2024

Closing to resend since git build is not runnable

@imesh94 imesh94 closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant