Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OB3] Role extraction improvement - add support to extract both PSD2 and PSP roles from the certificate as needed #210

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

Akila94
Copy link
Member

@Akila94 Akila94 commented Nov 29, 2024

[OB3] Role extraction improvement - add support to extract both PSD2 and PSP roles from the certificate as needed

  • This PR adds a new getter and a setter to set/get roles and PSD2 roles (AISP, PISP, etc) in formats from the CertificateContent class. The relevant variable is initialized when extracting the certificate content from the extract() method of the CertificateContentExtractor class.
  • The isRequiredRolesMatchWithScopes() method in CertValidationService class is changed to check for both psp and psd2 roles when validating the roles.
  • The unit tests are changed according to the above changes.

Related Issue link:
#163

Doc Issue: N/A

Applicable Labels: OB2


Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

aka4rKO
aka4rKO previously approved these changes Nov 29, 2024
@Akila94 Akila94 force-pushed the role-validation-improvement-2 branch from 57db825 to c9d6ba7 Compare December 10, 2024 05:21
…erator.common/src/main/java/com/wso2/openbanking/accelerator/common/model/PSD2RoleEnum.java

Co-authored-by: Anju Chamantha <[email protected]>
@Akila94 Akila94 dismissed stale reviews from anjuchamantha and aka4rKO via 0a195fd December 10, 2024 06:01
@aka4rKO aka4rKO merged commit aa73cf2 into wso2:3.0.0 Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants