[Accelerator 4] Adding real time event notification #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Ashi1993 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Akila94
reviewed
Dec 10, 2024
| </Import-Package> | ||
| <DynamicImport-Package>*</DynamicImport-Package> |
There was a problem hiding this comment.
As discussed offline, let's create an issue to remove this dynamic imports line in the future.
There was a problem hiding this comment.
Created issue #218
aka4rKO
reviewed
Dec 11, 2024
|
|
||
| /** | ||
| * Method to update the notification status by ID, allowed values are. | ||
| * OPEN,ACK and ERR |
There was a problem hiding this comment.
if only these values are allowed shouldn't we accept an enum?
aka4rKO
reviewed
Dec 11, 2024
| // the notification status will be updated as ERROR. | ||
| realtimeNotificationService.updateNotificationStatusById(notificationId, | ||
| EventNotificationConstants.ERROR); | ||
| } catch (IOException | InterruptedException e) { |
There was a problem hiding this comment.
if these both exception are logging the same error we can merge them
RivinduM
approved these changes
Dec 11, 2024
aka4rKO
approved these changes
Dec 11, 2024
11 tasks
|
Closing this PR and added this again because #224 due to an issue with CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding real time event notification
Issue link: https://github.com/wso2-enterprise/solutions-bfsi/issues/20
Doc Issue: Optional, link issue from documentation repository
Applicable Labels: Spec, product, version, type (specify requested labels)
Development Checklist
Testing Checklist