[Accelerator 4] Adding event notification endpoint implementation #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashi1993
changed the title
| if (!parameterMap.isEmpty() && parameterMap.containsKey(EventNotificationEndPointConstants.REQUEST)) { | ||
|
|
||
| requestData = parameterMap.get(EventNotificationEndPointConstants.REQUEST). | ||
| toString().replaceAll("\\\\r|\\\\n|\\r|\\n|\\[|]| ", StringUtils.EMPTY); |
There was a problem hiding this comment.
Shall we move this to a constant? "\\\\r|\\\\n|\\r|\\n|\\[|]| "
| //set events to notificationCreationDTO | ||
| JSONObject finalNotificationEvents = notificationEvents; | ||
| notificationEvents.keySet().forEach(eventName -> { | ||
| JSONObject eventInformation = (JSONObject) finalNotificationEvents.get(eventName); |
There was a problem hiding this comment.
Suggested change
| JSONObject eventInformation = (JSONObject) finalNotificationEvents.get(eventName); | |
| JSONObject eventInformation = finalNotificationEvents.getJSONObject(eventName); |
| } | ||
|
|
||
| //set events to notificationCreationDTO | ||
| JSONObject finalNotificationEvents = notificationEvents; |
There was a problem hiding this comment.
Why do we need this variable here?
| .getErrorDTO(EventNotificationEndPointConstants.INVALID_REQUEST_PAYLOAD, | ||
| EventNotificationEndPointConstants.REQUEST_PAYLOAD_ERROR)).build(); | ||
| } catch (FSEventNotificationException e) { | ||
| return Response.status(e.getStatus()).entity(EventNotificationServiceUtil |
There was a problem hiding this comment.
Missed the log here
| @Path("/events") | ||
| public class EventPollingEndpoint { | ||
|
|
||
| private static final Log log = LogFactory.getLog(EventCreationEndpoint.class); |
There was a problem hiding this comment.
Suggested change
| private static final Log log = LogFactory.getLog(EventCreationEndpoint.class); | |
| private static final Log log = LogFactory.getLog(EventPollingEndpoint.class); |
| public class EventPollingEndpoint { | ||
|
|
||
| private static final Log log = LogFactory.getLog(EventCreationEndpoint.class); | ||
| private static final EventPollingServiceHandler eventPollingServiceHandler = EventNotificationUtils. |
There was a problem hiding this comment.
It may get difficult to write unit tests with this approach. may be we could introduce a constructor?
| /** | ||
| * Events Notification Subscription API Utils. | ||
| */ | ||
| public class EventSubscriptionUtils { |
There was a problem hiding this comment.
Let's add a private constructor. applicable to other relevant places too
anjuchamantha
approved these changes
Dec 12, 2024
VimukthiRajapaksha
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Event Notification Endpoint Implementation
Issue link: https://github.com/wso2-enterprise/solutions-bfsi/issues/20
Doc Issue: Optional, link issue from documentation repository
Applicable Labels: Spec, product, version, type (specify requested labels)
Development Checklist
Testing Checklist