Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OB3][ConsentMgr] Added an empty success response when consent data is not available #149

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

aka4rKO
Copy link
Contributor

@aka4rKO aka4rKO commented Oct 21, 2024

[OB3][ConsentMgr] Added an empty success response when consent data is not available

Currently the consent manager portal shows an error page when there are no consents created and is engaged in an infinite loop trying to fetch data. This PR fixes the issue by returning an empty data json to handle this scenario.

Response body without consents
{"data":{}}

Response body with consents

{
    "data": {
        "<CLIENT_ID>": {
            "type": "oauth2",
            "Id": "<ID>",
            "metadata": {
                "software_id": "<SOFTWARE_ID>",
                "software_client_name": "WSO2 Open Banking TPP2 (Sandbox)",
                "logo_uri": "",
                "org_name": "WSO2 (UK) LIMITED",
                "client_name": ""
            }
        }
    }
}

Issue link: https://github.com/wso2-enterprise/wso2-ob-internal/issues/837

Applicable Labels: Spec, product, version, type (specify requested labels)


Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

@hasithakn hasithakn merged commit ca88e0d into wso2:3.0.0 Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants