-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accelerator 4] Adding Accelerator Gateway Implementation #127
Conversation
@@ -48,7 +48,7 @@ public class FSAPIRequestContext extends RequestContextDTO { | |||
|
|||
private static final Log log = LogFactory.getLog(FSAPIRequestContext.class); | |||
private final RequestContextDTO requestContextDTO; | |||
private Map<String, Object> contextProps; | |||
private Map<String, String> contextProps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we change this to a string? What if in the future we have a requirement to pass objects around the executor framework? Like for an example we extract the certificate in one executor and set it as a property and do some validations from another executor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree, Will keep it as <String, Object> map
Adding Accelerator Gateway Implementation
Issue link: https://github.com/wso2-enterprise/solutions-bfsi/issues/20
Doc Issue: Optional, link issue from documentation repository
Applicable Labels: Spec, product, version, type (specify requested labels)
Development Checklist
Testing Checklist