Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accelerator 4] Adding Accelerator Gateway Implementation #127

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

Ashi1993
Copy link
Contributor

@Ashi1993 Ashi1993 commented Sep 30, 2024

Adding Accelerator Gateway Implementation

This PR adds the Accelerator Gateway Implementation.

Issue link: https://github.com/wso2-enterprise/solutions-bfsi/issues/20

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)


Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

@Ashi1993 Ashi1993 changed the title Adding Accelerator Gateway Implemntation Adding Accelerator Gateway Implementation Sep 30, 2024
@@ -48,7 +48,7 @@ public class FSAPIRequestContext extends RequestContextDTO {

private static final Log log = LogFactory.getLog(FSAPIRequestContext.class);
private final RequestContextDTO requestContextDTO;
private Map<String, Object> contextProps;
private Map<String, String> contextProps;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we change this to a string? What if in the future we have a requirement to pass objects around the executor framework? Like for an example we extract the certificate in one executor and set it as a property and do some validations from another executor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, Will keep it as <String, Object> map

@aka4rKO aka4rKO merged commit 0a65db6 into wso2:main Oct 2, 2024
2 checks passed
@Ashi1993 Ashi1993 changed the title Adding Accelerator Gateway Implementation [Accelerator 4] Adding Accelerator Gateway Implementation Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants