Skip to content

Commit

Permalink
fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Ashi1993 committed Dec 4, 2024
1 parent 9fdacbc commit 4e3160f
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public EventSubscription createEventSubscription(EventSubscription eventSubscrip
DatabaseUtils.rollbackTransaction(connection);
throw new FSEventNotificationException(EventNotificationConstants.ERROR_STORING_EVENT_SUBSCRIPTION, e);
} finally {
log.debug(EventNotificationConstants.DATABASE_CONNECTION_CLOSE_LOG_MSG);
DatabaseUtils.closeConnection(connection);
}
}
Expand Down Expand Up @@ -102,6 +103,7 @@ public EventSubscription getEventSubscriptionBySubscriptionId(String subscriptio
DatabaseUtils.rollbackTransaction(connection);
throw new FSEventNotificationException(e.getMessage(), e);
} finally {
log.debug(EventNotificationConstants.DATABASE_CONNECTION_CLOSE_LOG_MSG);
DatabaseUtils.closeConnection(connection);
}
}
Expand Down Expand Up @@ -132,6 +134,7 @@ public List<EventSubscription> getEventSubscriptionsByClientId(String clientId)
DatabaseUtils.rollbackTransaction(connection);
throw new FSEventNotificationException(e.getMessage(), e);
} finally {
log.debug(EventNotificationConstants.DATABASE_CONNECTION_CLOSE_LOG_MSG);
DatabaseUtils.closeConnection(connection);
}
}
Expand Down Expand Up @@ -163,6 +166,7 @@ public List<EventSubscription> getEventSubscriptionsByEventType(String eventType
DatabaseUtils.rollbackTransaction(connection);
throw new FSEventNotificationException(e.getMessage(), e);
} finally {
log.debug(EventNotificationConstants.DATABASE_CONNECTION_CLOSE_LOG_MSG);
DatabaseUtils.closeConnection(connection);
}
}
Expand Down Expand Up @@ -223,6 +227,7 @@ public Boolean updateEventSubscription(EventSubscription eventSubscription)
DatabaseUtils.rollbackTransaction(connection);
throw new FSEventNotificationException(e.getMessage(), e);
} finally {
log.debug(EventNotificationConstants.DATABASE_CONNECTION_CLOSE_LOG_MSG);
DatabaseUtils.closeConnection(connection);
}
}
Expand Down Expand Up @@ -254,6 +259,7 @@ public Boolean deleteEventSubscription(String subscriptionId) throws FSEventNoti
DatabaseUtils.rollbackTransaction(connection);
throw new FSEventNotificationException(e.getMessage(), e);
} finally {
log.debug(EventNotificationConstants.DATABASE_CONNECTION_CLOSE_LOG_MSG);
DatabaseUtils.closeConnection(connection);
}
}
Expand Down

0 comments on commit 4e3160f

Please sign in to comment.