Update authenticator and idp management APIs #5140
Open
+1,270
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thisara-Welmilla
force-pushed
the
update-auth-APIs
branch
from
573d7f5 to
3a8d820
Compare
malithie
reviewed
Mar 5, 2025
| id: "Y3VzdG9tQXV0aGVudGljYXRvcg" | ||
| name: "customAuthenticator" | ||
| displayName: "Custom auth" | ||
| definedBy: "SYSTEM" |
malithie
reviewed
Mar 5, 2025
| id: "QmFzaWNBdXRoZW50aWNhdG9y" | ||
| name: "BasicAuthenticator" | ||
| displayName: "basic" | ||
| definedBy: "USER" |
malithie
reviewed
Mar 5, 2025
| definedBy: "USER" | ||
| type: "LOCAL" | ||
| isEnabled: true | ||
| tags: [ Custom, 2FA ] |
There was a problem hiding this comment.
These tags should go to the previous
malithie
reviewed
Mar 5, 2025
| properties: | ||
| username: "auth_username" | ||
| password: "auth_password" | ||
| SystemDefinedAuthenticatorExample: |
There was a problem hiding this comment.
Also this sample doesn't seem to apply at /custom path
isn't it ?
malithie
reviewed
Mar 5, 2025
| - isEnabled | ||
| - endpoint | ||
| UserDefinedLocalAuthenticatorUpdate: | ||
| description: TThis represents the configuration for updating user defined local authenticator. |
malithie
reviewed
Mar 5, 2025
| @@ -1239,9 +1283,20 @@ components: | |||
| displayName: | |||
| type: string | |||
| example: basic | |||
| description: | |||
| type: string | |||
| example: "Description for user defined local authenticator configuration." | |||
There was a problem hiding this comment.
Isn't this model commonly used for both system defined and user defined
malithie
reviewed
Mar 5, 2025
| @@ -1208,10 +1241,21 @@ components: | |||
| displayName: | |||
| type: string | |||
| example: basic | |||
| description: | |||
| type: string | |||
| example: "Description for user defined local authenticator configuration." | |||
There was a problem hiding this comment.
Isn't this model commonly used for both user defined and system defined ? I don't think we can give this description in that case
malithie
reviewed
Mar 5, 2025
Comment on lines
+3469
to
+3473
| description: "IdP for Google Federation" | ||
| image: "google-logo-url" | ||
| templateId: "8ea23303-49c0-4253-b81f-82c0fe6fb4a0" | ||
| isPrimary: false |
There was a problem hiding this comment.
This should be something custom
malithie
reviewed
Mar 5, 2025
Comment on lines
+3542
to
+3549
| name: "Custom IDP" | ||
| description: "IDP with custom federated authenticator" | ||
| image: "https://custom-authenticator-logo-url" | ||
| templateId: "8ea23303-49c0-4253-b81f-82c0fe6fb4a0" | ||
| isPrimary: false | ||
| isFederationHub: false | ||
| homeRealmIdentifier: "" |
There was a problem hiding this comment.
This is for system defined IdP. Looks like you have swapped the content of two examples
malithie
reviewed
Mar 5, 2025
| userstore: "PRIMARY" | ||
| associateLocalUser: true | ||
| attributeSyncMethod: "OVERRIDE_ALL" |
malithie
reviewed
Mar 5, 2025
| id: "Y3VzdG9tQXV0aGVudGljYXRvcg" | ||
| name: "customAuthenticator" | ||
| displayName: "Custom auth" | ||
| definedBy: "SYSTEM" |
malithie
reviewed
Mar 5, 2025
| id: "QmFzaWNBdXRoZW50aWNhdG9y" | ||
| name: "BasicAuthenticator" | ||
| displayName: "basic" | ||
| definedBy: "USER" |
malithie
reviewed
Mar 5, 2025
| @@ -3280,4 +3389,191 @@ components: | |||
| file: | |||
| type: string | |||
| format: binary | |||
| description: file to upload | |||
malithie
reviewed
Mar 5, 2025
| authenticatorId: "Y3VzdG9tQXV0aGVudGljYXRvcg" | ||
| name: "customAuthenticator" | ||
| definedBy: "SYSTEM" |
malithie
reviewed
Mar 5, 2025
| value: | ||
| authenticatorId: "U0FNTDJBdXRoZW50aWNhdG9y" | ||
| definedBy: "USER" |
malithie
reviewed
Mar 5, 2025
| userstore: "PRIMARY" | ||
| associateLocalUser: true | ||
| attributeSyncMethod: "OVERRIDE_ALL" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Update the API docs on follwoing endpoints: