Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove role and claim mapping from Organization Application API #5093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove role and claim mapping from Organization Application API #5093

wants to merge 1 commit into from
+192 −42

Conversation

HasiniSama
Copy link
Contributor

@HasiniSama HasiniSama commented Feb 21, 2025 •
edited
Loading

Purpose

&subject

Fixes: wso2/product-is#23221

Fixes the error thrown when using the sample curl given:

Screenshot 2025-02-21 at 21 30 57 
"code": "APP-60001",
    "message": "Error patching application with id: d9a93339-b23c-479f-b434-54049593fc8c",
    "description": "Invalid application configuration for application: 'pickup2' of tenantDomain: 9870650c-f4b5-43a0-8977-d0650dea04f2. Groups including: admin, are prohibited for role mapping. Use roles instead.",
    "traceId": "bede6c21-8e7a-4ba2-85da-dfe6b6d76c8e"
}

@HasiniSama HasiniSama changed the title Remove role mapping from application PATCH API Remove role mapping from application PATCH API sample curl Feb 21, 2025
@HasiniSama HasiniSama force-pushed the fix-org-app-patch-api branch 4 times, most recently from 75e8bc8 to 00fc714 Compare February 21, 2025 16:15
@HasiniSama HasiniSama mentioned this pull request Feb 21, 2025
Open
AnuradhaSK
AnuradhaSK previously approved these changes Feb 21, 2025
View reviewed changes
@HasiniSama HasiniSama force-pushed the fix-org-app-patch-api branch from 00fc714 to 2496fd1 Compare February 21, 2025 16:32
@HasiniSama HasiniSama changed the title Remove role mapping from application PATCH API sample curl Remove role and claim mapping from application PATCH API sample curl Feb 21, 2025
@HasiniSama HasiniSama changed the title Remove role and claim mapping from application PATCH API sample curl Remove role and claim mapping from Organization Application API Feb 21, 2025
@HasiniSama HasiniSama force-pushed the fix-org-app-patch-api branch 2 times, most recently from 8fb7a11 to 2dbc945 Compare February 21, 2025 16:39
@HasiniSama HasiniSama force-pushed the fix-org-app-patch-api branch 2 times, most recently from a9188f6 to 0e79167 Compare February 21, 2025 19:26
@HasiniSama HasiniSama force-pushed the fix-org-app-patch-api branch from 0e79167 to 7614970 Compare February 26, 2025 04:44
HasiniSama
HasiniSama commented Feb 26, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
self: "/o/api/server/v1/applications/85e3f4b8-0d22-4181-b1e3-1651f71b88bd"
links:
- href: "applications?offset=10&limit=10"
rel: "next"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-26 at 10 00 56

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
mandatory: false
subject:
claim:
uri: "http://wso2.org/claims/username"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{uri: "http://wso2.org/claims/userid"}
this the default sub we used in IS now
Let's change this

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
mandatory: false
subject:
claim:
uri: "http://wso2.org/claims/username"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the subject to userid

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
Comment on lines +403 to +406
additionalSpProperties:
- name: "isInternalApp"
value: "true"
displayName: "Internal Application"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove additionalSpProperties

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
claim:
uri: "http://wso2.org/claims/roles"
advancedConfigurations:
saas: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove saas

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
useExternalConsentPage: false
returnAuthenticatedIdpList: false
enableAuthorization: true
fragment: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove fragment property

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
Comment on lines +391 to +402
attestationMetaData:
enableClientAttestation: false
androidPackageName: "com.wso2.mobile.sample"
androidAttestationServiceCredentials: {}
appleAppId: "APPLETEAMID.com.wso2.mobile.sample"
trustedAppConfiguration:
isFIDOTrustedApp: false
isConsentGranted: false
androidPackageName: "com.wso2.mobile.sample"
androidThumbprints:
- "18:94:0A:DE:63:77:B6:84:43:1E:85:8F:03:CF:8A:14:87:9C:DE:DF:EA:7A:25:53:CD:53:5A:AF:C3:54:A5:56"
appleAppId: "APPLETEAMID.com.org.mobile.sample"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
"mandatory": false
}
],
"subject": {
"claim": {
"uri": "http://wso2.org/claims/username"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change subject userid

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
Comment on lines +499 to 519
"attestationMetaData": {
"enableClientAttestation": false,
"androidPackageName": "com.wso2.mobile.sample",
"androidAttestationServiceCredentials": {},
"appleAppId": "APPLETEAMID.com.wso2.mobile.sample"
},
"trustedAppConfiguration": {
"isFIDOTrustedApp": false,
"isConsentGranted": false,
"androidPackageName": "com.wso2.mobile.sample",
"androidThumbprints": [
"18:94:0A:DE:63:77:B6:84:43:1E:85:8F:03:CF:8A:14:87:9C:DE:DF:EA:7A:25:53:CD:53:5A:AF:C3:54:A5:56"
],
"appleAppId": "APPLETEAMID.com.org.mobile.sample"
},
"additionalSpProperties": [
{
"localRole": "admin",
"applicationRole": "Administrator"
"name": "isInternalApp",
"value": "true",
"displayName": "Internal Application"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
"useExternalConsentPage": false,
"returnAuthenticatedIdpList": false,
"enableAuthorization": true,
"fragment": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove fragment

AnuradhaSK
AnuradhaSK reviewed Mar 5, 2025
View reviewed changes
en/identity-server/next/docs/apis/organization-apis/restapis/org-application-mgt.yaml
"role": {
"mappings": [
"advancedConfigurations": {
"saas": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove saas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaSK AnuradhaSK AnuradhaSK left review comments

@SujanSanjula96 SujanSanjula96 SujanSanjula96 left review comments

@himeshsiriwardana himeshsiriwardana Awaiting requested review from himeshsiriwardana

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Organization Application PATCH API sample curl
3 participants
@HasiniSama @AnuradhaSK @SujanSanjula96