Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude system apps in applications GET impl #6026

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JeethJJ
Copy link
Contributor

@JeethJJ JeethJJ commented Oct 14, 2024

Introduce excludeSystemPortals API query param and following implementation.
Introduce systemPortals server level config and implementation to exclude the mentioned systemPortals in get applications api response.

Proposed changes in this pull request

  1. Add a system_portals toml config to maintain the list of system portals to be excluded when listing Applications via the API.
  2. Update DB queries for the following requirements.
  • To get the count of applications excluding system portals.
  • To retrieve application basic info excluding system portals.

…tation. Introduce systemPortals server level config and implementation to exclude the mentioned systemPortals in get applications api response.
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 40.19%. Comparing base (ba952e5) to head (9ab5dad).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...y/application/mgt/dao/impl/ApplicationDAOImpl.java 75.00% 6 Missing and 1 partial ⚠️
...n/mgt/dao/PaginatableFilterableApplicationDAO.java 0.00% 3 Missing ⚠️
...ication/mgt/ApplicationPaginationAndSearching.java 0.00% 2 Missing ⚠️
...cation/mgt/dao/impl/CacheBackedApplicationDAO.java 66.66% 2 Missing ⚠️
.../application/mgt/ApplicationManagementService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6026      +/-   ##
============================================
+ Coverage     40.12%   40.19%   +0.06%     
+ Complexity    14198    14187      -11     
============================================
  Files          1736     1738       +2     
  Lines        117216   116944     -272     
  Branches      20200    20126      -74     
============================================
- Hits          47035    47000      -35     
+ Misses        62938    62730     -208     
+ Partials       7243     7214      -29     
Flag Coverage Δ
unit 23.97% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shanggeeth
shanggeeth previously approved these changes Oct 16, 2024
@shanggeeth
Copy link
Contributor

Let's run the PR builder before merging.

@janakamarasena
Copy link
Member

Make sure to update the integration tests cover the new cases.

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11367350879
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11367350879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants