Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tenant ID Addition of Newly Added Scopes of Exiting System APIs #6018

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Oct 11, 2024

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.11%. Comparing base (a52bcdc) to head (6948c4b).
Report is 59 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6018      +/-   ##
============================================
- Coverage     40.17%   40.11%   -0.06%     
- Complexity    14170    14202      +32     
============================================
  Files          1734     1736       +2     
  Lines        116957   117376     +419     
  Branches      20022    20185     +163     
============================================
+ Hits          46988    47090     +102     
- Misses        62750    63052     +302     
- Partials       7219     7234      +15     
Flag Coverage Δ
unit 23.96% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11294207631
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11294207631

@dhaura
Copy link
Contributor Author

dhaura commented Oct 14, 2024

@dhaura dhaura closed this Oct 14, 2024
@dhaura dhaura reopened this Oct 16, 2024
@dhaura
Copy link
Contributor Author

dhaura commented Oct 16, 2024

  • When an API belongs to all tenants, in db the tenant id is set to null for all API scopes. Therefore, having tenant id equals to zero can cause confusion in the service layer. Therefore, it was finally decided to bring the check to the DAO layer.
  • Hence, the PR was reopened.

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11366348597
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11366348597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants