Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor action execution request data model #6006

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

Shenali-SJ
Copy link
Contributor

@Shenali-SJ Shenali-SJ commented Oct 9, 2024

Description

This PR updateds the action execution component by refactoring the data types of the additionalHeaders and additionalParams fields in the action request object to align with the API contract.

Updated request object:

{
    "additionalHeaders": [
        {
            "name": "accept",
            "value": [
                "application/json"
            ]
        },
        {
            "name": "cache-control",
            "value": [
                "no-cache"
            ]
        }
    ],
    "additionalParams": [
        {
            "name": "TestParam",
            "value": [
                "test"
            ]
        }
    ],
    "clientId": "r***************************a",
    "grantType": "client_credentials",
    "scopes": [
        "test_scope_1",
        "test_scope_2"
    ]
}

Related Issue:

Related PRs:

Followup Actions:

@Shenali-SJ Shenali-SJ force-pushed the action-execution-data-refactor branch from 3f8800e to 311b713 Compare October 10, 2024 05:09
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.10%. Comparing base (278ba34) to head (b1aae9d).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...arbon/identity/action/execution/model/Request.java 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6006      +/-   ##
============================================
- Coverage     40.16%   40.10%   -0.07%     
- Complexity    14170    14180      +10     
============================================
  Files          1734     1736       +2     
  Lines        116973   117269     +296     
  Branches      20027    20153     +126     
============================================
+ Hits          46988    47036      +48     
- Misses        62766    62992     +226     
- Partials       7219     7241      +22     
Flag Coverage Δ
unit 23.93% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@malithie malithie merged commit 1935878 into wso2:master Oct 10, 2024
2 checks passed
@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11273248294
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants