Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jdbc scope validator invalid scope issue #5764

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

bhagyasakalanka
Copy link
Contributor

When jdbc scope validator is enabled, the scopes are not properly validated due to a fix added with PR[1]. The PR[1] was added with the intention of supporting scopes with case sensitivity. The PR[1] uses environmental variable preservedCaseSensitive to determine if case sensitivity is enabled or not. This PR will add a separate config to configure this behavior via deployment.toml file.

With this PR, we will not change the default behavior which is preserve case sensitivity false.

Add following config to deployment.toml file to enable/disable case sensitivity for jdbc scope validator

[oauth.scope_validator]
preserve_case_sensitivity=true

Related Issues

Related PRs

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9674385932
Status: failure

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9677612851
Status: failure

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9833517684
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9833517684

@bhagyasakalanka bhagyasakalanka merged commit c58e6bd into wso2:master Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants