Add null checks and default values for backend related metric properties #12211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamilaadhi
reviewed
Jan 23, 2024
.../org/wso2/carbon/apimgt/gateway/handlers/analytics/SynapseAnalyticsDataProviderTestCase.java
Show resolved
Hide resolved
chamilaadhi
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds null checks and default values for backend related metric properties.
When a respond mediator is included in the request path, the gateway will not forward the request to the backend. In such cases, we need to populate the metrics related to backend in order to avoid errors in the flow. The following metrics were handled through this PR.
Related issue: https://github.com/wso2-enterprise/wso2-apim-internal/issues/5285
Fixes wso2/api-manager#2364